Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #216

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update README.md #216

wants to merge 2 commits into from

Conversation

tushar-kumar
Copy link

@tushar-kumar tushar-kumar commented Oct 28, 2022 •
edited
Loading

xml cheatsheet added

What does this PR do?

Add content(s) | Remove content(s) | Add new CheatSheet | Add new feature | Bug fix

Description

here is your description

Screenshots or Links

If applicable, add screenshots or a modified UI link to help understand your contribution.

Additional context

Add any other context about your PR.

Checklist:

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@tushar-kumar
Update README.md
1adea75 
xml cheatsheet added
github-actions[bot]
github-actions bot reviewed Oct 28, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

Thanks for joining our community - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@crescentpartha crescentpartha added hacktoberfest Hacktoberfest Participation hacktoberfest-2022 Hacktoberfest-2022 Participation 📝review-pull-request Reviewing your pull request labels Oct 28, 2022
crescentpartha
crescentpartha requested changes Oct 28, 2022
View reviewed changes
Copy link
Owner

@crescentpartha crescentpartha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request to change your file as per the below requirements.

README.md Outdated
@@ -63,6 +63,7 @@ A Collection of programming [CheatSheets](./CheatSheets/) for developers to quic
30. [nodejs-cheatsheet.md](./CheatSheets/nodeJs-cheatsheet.md)
31. [mongodb-cheatsheet.md](./CheatSheets/mongodb-cheatsheet.md)
32. [extension-cheatsheet.md](./CheatSheets/extension-cheatsheet.md)
33. [xml-cheatsheet.md](./CheatSheets/XML-cheatsheet.md)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added XML-cheatsheet.md file in README.md. But where is your XML-cheatsheet file? You didn't create the XML-cheatsheet file yet.

Please, rename your file XML-cheatsheet.md to xml-cheatsheet.md.

tushar-kumar
tushar-kumar commented Oct 28, 2022
View reviewed changes
Copy link
Author

@tushar-kumar tushar-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name changed from XML-cheatsheet.md to xml-cheatsheet.md

@crescentpartha crescentpartha added modifications-needed Modify the code waiting-for-changes Waiting for require changes labels Oct 28, 2022
@crescentpartha
Copy link
Owner

name changed from XML-cheatsheet.md to xml-cheatsheet.md

This PR will be merged after merging the #215 PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@crescentpartha crescentpartha crescentpartha requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@tushar-kumar tushar-kumar

Labels
hacktoberfest Hacktoberfest Participation hacktoberfest-2022 Hacktoberfest-2022 Participation modifications-needed Modify the code 📝review-pull-request Reviewing your pull request waiting-for-changes Waiting for require changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tushar-kumar @crescentpartha