Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring yarn in slug #144

Merged
merged 2 commits into from
Apr 26, 2017
Merged

Ignoring yarn in slug #144

merged 2 commits into from
Apr 26, 2017

Conversation

albatrocity
Copy link
Contributor

@albatrocity albatrocity commented Apr 26, 2017

Fixes #142, phantomjs-prebuilt issues (see this)

@albatrocity albatrocity temporarily deployed to scribble-corpse-pr-144 April 26, 2017 13:59 Inactive
@albatrocity albatrocity requested review from roblafeve and dmdez April 26, 2017 14:19
@albatrocity
Copy link
Contributor Author

@dmdez @roblafeve confirmed, this fixes #142. How do we feel about abandoning yarn, at least on Heroku?

@dmdez
Copy link
Contributor

dmdez commented Apr 26, 2017

Only other idea I had was to find a way to keep yarn and disable on heroku deployments (somehow).

@dmdez
Copy link
Contributor

dmdez commented Apr 26, 2017

Looks like we should be able to add yarn.lock to a .slugignore file? Much like a .gitignore.
https://devcenter.heroku.com/articles/slug-compiler#ignoring-files-with-

If this works, we can keep yarn for our own selfish needs.... However, one could still run into yarn build issues locally.

@albatrocity
Copy link
Contributor Author

@dmdez it's auto-detected, but maybe we could do a postinstall hook that runs npm install pantomjs-prebuilt?

@albatrocity
Copy link
Contributor Author

Ah, nice, I'll try a .slugignore

@albatrocity
Copy link
Contributor Author

@dmdez bingo, that works. Local stuff can still be run with yarn dev, etc.

@albatrocity albatrocity changed the title Removing yarn 😢 Ignoring yarn in slug Apr 26, 2017
Copy link

@roblafeve roblafeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crisis averted 😄

@dmdez
Copy link
Contributor

dmdez commented Apr 26, 2017

Merge away as you wish

@albatrocity albatrocity merged commit 3b370f8 into master Apr 26, 2017
@albatrocity albatrocity deleted the png-fix-npm branch April 26, 2017 14:45
@albatrocity
Copy link
Contributor Author

albatrocity commented Apr 26, 2017

@dmdez you should have what you need for #95 in master now 😁 (only for new completions for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants