-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignoring yarn in slug #144
Conversation
@dmdez @roblafeve confirmed, this fixes #142. How do we feel about abandoning yarn, at least on Heroku? |
Only other idea I had was to find a way to keep yarn and disable on heroku deployments (somehow). |
Looks like we should be able to add If this works, we can keep yarn for our own selfish needs.... However, one could still run into yarn build issues locally. |
@dmdez it's auto-detected, but maybe we could do a postinstall hook that runs |
Ah, nice, I'll try a |
@dmdez bingo, that works. Local stuff can still be run with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crisis averted 😄
Merge away as you wish |
Fixes #142,
phantomjs-prebuilt
issues (see this)