Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] NavPills horizontal can not click #69

Closed
clwater opened this issue Oct 26, 2020 · 6 comments · Fixed by #85
Closed

[Bug] NavPills horizontal can not click #69

clwater opened this issue Oct 26, 2020 · 6 comments · Fixed by #85
Labels
bug Something isn't working enhancement New feature or request

Comments

@clwater
Copy link

clwater commented Oct 26, 2020

Version

v1.9

Reproduction link

https://jsfiddle.net/

Operating System

Mac

Device

PC

Browser & Version

Version 86.0.4240.111 (Official Build) (x86_64)

Steps to reproduce

add NavPills
set NavPills direction is horizontal ( as your provide example)
add 2 tabs
change the Chrome size

What is expected?

when i change the Chrome size, in sm size, the tab view over the tabButton, i can not click the tabButton.

What is actually happening?

when i change the Chrome size,
in ant size, i can click any tabButton;


Solution

Additional comments

@einazare
Copy link
Contributor

Hello again, @clwater ,

The provided reproduction link redirects me on a blank jsfiddle. Was this intentional?
Screen Shot 2020-10-27 at 8 32 25 AM

I've tested your issue, but I couldn't reproduce it, here is proof: https://imgur.com/a/M825Vzb

Could you please give us a similar video with the issue?

Best,
Manu

@einazare einazare added the question Further information is requested label Oct 27, 2020
@clwater
Copy link
Author

clwater commented Oct 27, 2020

@einazare
I provide an demo in this issues.
link as https://i.imgur.com/XOtwuuT.gifv
is my tabsGrid or contentGrid have any question?

@einazare
Copy link
Contributor

Hello again, @clwater ,

I did another check and it seems that they work as expected: https://imgur.com/a/lRZPvUk
Could you please tell us if you did any changes to our CSS/JSS/SCSS, or did you add new CSS/JSS/SCSS? Also, did you made changed to any of our dependencies? Or did you add new plugins to the NavPills component?
Anything that you changed, please leave it here, and I'll make further testings with the mentioned changes.

Best,
Manu

@clwater
Copy link
Author

clwater commented Oct 29, 2020

Hi @einazare
I am look for you provideo video,
This is my new test in this issues, https://imgur.com/9nS0WDV
In this video , i use your provide code template,
I just change the
horizontal={{
tabsGrid: { xs: 12, sm: 3, md: 4 },
contentGrid: { xs: 12, sm: 9, md: 8 }
}}
as
horizontal={{
tabsGrid: { xs: 12, sm: 1, md: 1 },
contentGrid: { xs: 12, sm: 11, md: 11 }
}}
, not change any other code, but in webview, the NavPills tab body over the tab header

@einazare
Copy link
Contributor

Hello again, @clwater ,

Now I understand the issue at hand.
It seems we've made a mistake and did not calculate the posibility our users would actually use sm: 1, md: 1, lg: 1 for the tabsGrid.
To stop having this issue, please, do not use lower values of 3 for the tabsGrid widths.
In our next update, we will add an error for this.

Best,
Manu

@einazare einazare added bug Something isn't working enhancement New feature or request and removed question Further information is requested labels Oct 30, 2020
@clwater
Copy link
Author

clwater commented Oct 30, 2020

@einazare
Ok, im understand, It look like i need change my web ui design.

einazare added a commit that referenced this issue May 12, 2021
Closes #82
Closes #78
Closes #76
Closes #69
Closes #49
einazare added a commit that referenced this issue May 12, 2021
Closes #82
Closes #78
Closes #76
Closes #69
Closes #49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants