Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Making Code and Comments consistent in codebase for Better Readability and Understanding #89

Closed
wants to merge 14 commits into from

Conversation

IamMQaisar
Copy link
Contributor

@IamMQaisar IamMQaisar commented Mar 16, 2024

Fixes

Description

Modifications were made to the files related to comments, realigned the code for better understanding, removed repeatedly used files, and used only once from the root.

Technical details

legal-tool-paths.txt is moved from directories to the root directory so that it can be used for all related scripts from a single place. Also, the root_path instance is made to be used for both .env and legal-tool-paths.txt.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@IamMQaisar IamMQaisar requested review from a team as code owners March 16, 2024 19:57
@IamMQaisar IamMQaisar requested review from Shafiya-Heena and possumbilities and removed request for a team March 16, 2024 19:57
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! just a couple of requested changes

deviantart/deviantart_scratcher.py Outdated Show resolved Hide resolved
google_custom_search/google_scratcher.py Outdated Show resolved Hide resolved
@TimidRobot TimidRobot self-assigned this Mar 16, 2024
@IamMQaisar
Copy link
Contributor Author

IamMQaisar commented Mar 17, 2024

This Pull needs to be reviewed first, then logging #90 and so in the end Shared Scripts #95 Pull Request.
As it will break down the process, because concurrent changes in logging files, and then sharing scripts are introduced.

@IamMQaisar
Copy link
Contributor Author

IamMQaisar commented Mar 17, 2024

Closing this Pull and doing all issues #86 #85 and #91 solutions in a single pull #95. This will show you only the latest changes, with organized code, added logger, and shared module, to help you not get cluttered in the codebase with multiple changes. @TimidRobot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making Code and Comments consistent in codebase for Better Readability and Understanding
2 participants