use Mutex even for const methods

const does not mean const here? but it seems to be necessary to stay thread save
cre4ture · Aug 5, 2019 · 48cd13f · 48cd13f
1 parent 15bbb1c
commit 48cd13f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/chunkcache.cpp b/chunkcache.cpp
@@ -59,9 +59,9 @@ QString ChunkCache::getPath() {
 
 Chunk *ChunkCache::fetch(int x, int z) {
   ChunkID id(x, z);
-  //mutex.lock();
+  mutex.lock();
   Chunk *chunk = cache[id];   // const operation
-  //mutex.unlock();
+  mutex.unlock();
   if (chunk != NULL) {
     if (chunk->loaded)
       return chunk;

diff --git a/chunkloader.cpp b/chunkloader.cpp
@@ -45,9 +45,9 @@ void ChunkLoader::run() {
   }
   // get existing Chunk entry from Cache
   ChunkID id(x, z);
-  //mutex->lock();
+  mutex->lock();
   Chunk *chunk = cache[id];   // const operation
-  //mutex->unlock();
+  mutex->unlock();
   // parse Chunk data
   // Chunk will be flagged "loaded" in a thread save way
   if (chunk) {