Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the wind farm Jupyter notebook for new data links. #791

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Updated the wind farm Jupyter notebook for new data links. #791

merged 1 commit into from
Jan 9, 2025

Conversation

simonprickett
Copy link
Contributor

Changed the wind farm Jupyter notebook to use new data links as it is no longer wise to directly access LFS files from GitHub.

@simonprickett simonprickett added the bug Something isn't working label Jan 9, 2025
@simonprickett simonprickett self-assigned this Jan 9, 2025
surister
surister approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@surister surister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got
image
while checking the links in firefox, not sure if it actually affects the notebook, if it doesn't then LGTM

@simonprickett
Copy link
Contributor Author

I got image while checking the links in firefox, not sure if it actually affects the notebook, if it doesn't then LGTM

I think this is because it's really JSONL so the broswer won't render it.

@simonprickett simonprickett merged commit a51fc08 into main Jan 9, 2025
@simonprickett simonprickett deleted the update-windfarm-jupyter-new-data-url branch January 9, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surister surister surister approved these changes

@amotl amotl Awaiting requested review from amotl

Assignees

@simonprickett simonprickett

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonprickett @surister