Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLFrame: On the "all-types" validation, use char instead of character #767

Merged
merged 1 commit into from
Jan 17, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions by-dataframe/sqlframe/example_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def connect_spark():
bit="01010101",
bool=True,
text="foobar",
character="foo",
char="foo",
timestamp_tz="1970-01-02T00:00:00+01:00",
timestamp_notz="1970-01-02T00:00:00",
ip="127.0.0.1",
Expand All @@ -64,7 +64,7 @@ def connect_spark():
RECORD_OUT = deepcopy(RECORD_IN)
RECORD_OUT.update(
dict(
character="foo ",
char="foo ",
timestamp_tz=dt.datetime(1970, 1, 1, 23, 0, tzinfo=dt.timezone.utc),
timestamp_notz=dt.datetime(1970, 1, 2, 0, 0, tzinfo=dt.timezone.utc),
# FIXME: `geopoint` comes back as string, `'(85.42999997735023,66.22999997343868)'`
Expand Down Expand Up @@ -106,7 +106,7 @@ def sqlframe_ddl_dml_dql():
bit BIT(8),
bool BOOLEAN,
text TEXT,
character CHARACTER(5),
char CHAR(5),
timestamp_tz TIMESTAMP WITH TIME ZONE,
timestamp_notz TIMESTAMP WITHOUT TIME ZONE,
ip IP,
Expand Down
Loading