Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix CodeQL and Release jobs #673

Merged
merged 1 commit into from
Nov 7, 2024
Merged

CI: Fix CodeQL and Release jobs #673

merged 1 commit into from
Nov 7, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 6, 2024

A few aftermath fixes that have been revealed by running the release procedure.

@cla-bot cla-bot bot added the cla-signed label Nov 6, 2024
Comment on lines -31 to +32
language: [ python ]
matrix:
language: [ python ]
Copy link
Member Author

@amotl amotl Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to the release procedure, but didn't see it previously. It looks like GitHub had been lenient on a previous wrong definition here, but stopped being so.

Invalid workflow file: .github/workflows/codeql.yml#L31
The workflow is not valid. .github/workflows/codeql.yml (Line: 31, Col: 7): Unexpected value 'language'

-- https://github.com/crate/crate-python/actions/runs/11703225760

uv pip install build twine wheel
uv pip install --system build twine wheel
Copy link
Member Author

@amotl amotl Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's a hiccup from my previous "improvements".

error: No virtual environment found; run `uv venv` to create an environment, or pass `--system` to install into a non-virtual environment
Error: Process completed with exit code 2.

-- https://github.com/crate/crate-python/actions/runs/11703279293/job/32593274764#step:5:14

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@amotl amotl requested review from kneth and surister November 6, 2024 12:43
@amotl amotl marked this pull request as ready for review November 6, 2024 12:50
@amotl amotl merged commit 5759570 into main Nov 7, 2024
19 checks passed
@amotl amotl deleted the fix-ci branch November 7, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants