Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbox: Update build environment to use Node.js 22 #571

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Sandbox: Update build environment to use Node.js 22 #571

merged 1 commit into from
Jan 27, 2025

Conversation

amotl
Copy link
Member

@amotl amotl commented Jan 24, 2025

About

Bump sandbox from Node.js 18 to Node.js 22.

Backlog

Non-blocking.

@msbt: The make bundle-develop step bears a few deprecation warnings (see RTD build 26963098). It is probably on Furo to fix most of them?

@amotl amotl requested review from msbt and surister January 24, 2025 22:07
@amotl amotl marked this pull request as ready for review January 24, 2025 22:07
@msbt
Copy link
Collaborator

msbt commented Jan 27, 2025

@amotl yes, the warnings are courtesy of the sass package, when we replaced node-sass with it. The local build is successful, however, if I run make dev after make reset, those random .py errors show up (always a different file) and continue in a restart loop:

...
build succeeded.

The HTML pages are in .crate-docs/.build.
[I 250127 11:32:35 server:331] Serving on http://127.0.0.1:8000
[I 250127 11:32:35 handlers:62] Start watching changes
[I 250127 11:32:35 handlers:64] Start detecting changes
[I 250127 11:32:36 handlers:135] Browser Connected: http://127.0.0.1:8000/
[I 250127 11:32:36 watcher:104] Running task: build (delay: None)
[sphinx-autobuild] Detected change: /removed/crate-docs-theme/docs/.crate-docs/.venv/lib64/python3.12/site-packages/OleFileIO_PL.py
[sphinx-autobuild] > sphinx-build -n -W /removed/crate-docs-theme/docs /removed/crate-docs-theme/docs/.crate-docs/.build
Running Sphinx v7.1.2
...
build succeeded.

The HTML pages are in .crate-docs/.build.
[sphinx-autobuild] Serving on http://127.0.0.1:8000
[I 250127 11:29:18 handlers:92] Reload 1 waiters: /removed/crate-docs-theme/docs/.crate-docs/.venv/lib64/python3.12/site-packages/dbfread/test_invalid_value.py
[I 250127 11:29:18 handlers:135] Browser Connected: http://127.0.0.1:8000/
[I 250127 11:29:19 watcher:104] Running task: build (delay: None)
[sphinx-autobuild] Detected change: /removed/crate-docs-theme/docs/.crate-docs/.venv/lib64/python3.12/site-packages/dbfread/dbversions.py
[sphinx-autobuild] > sphinx-build -n -W /removed/crate-docs-theme/docs /removed/crate-docs-theme/docs/.crate-docs/.build
Running Sphinx v7.1.2
...
build succeeded.

The HTML pages are in .crate-docs/.build.
[sphinx-autobuild] Serving on http://127.0.0.1:8000
[I 250127 11:29:22 handlers:92] Reload 1 waiters: /removed/crate-docs-theme/docs/.crate-docs/.venv/lib64/python3.12/site-packages/dbfread/dbversions.py
[I 250127 11:29:23 handlers:135] Browser Connected: http://127.0.0.1:8000/
[I 250127 11:29:23 watcher:104] Running task: build (delay: None)
[sphinx-autobuild] Detected change: /removed/crate-docs-theme/docs/.crate-docs/.venv/lib64/python3.12/site-packages/dbfread/test_read_and_length.py
[sphinx-autobuild] > sphinx-build -n -W /removed/crate-docs-theme/docs /removed/crate-docs-theme/docs/.crate-docs/.build
Running Sphinx v7.1.2
...
build succeeded.

The HTML pages are in .crate-docs/.build.
[sphinx-autobuild] Serving on http://127.0.0.1:8000
[I 250127 11:29:26 handlers:92] Reload 1 waiters: /removed/crate-docs-theme/docs/.crate-docs/.venv/lib64/python3.12/site-packages/dbfread/test_read_and_length.py
[I 250127 11:29:26 handlers:135] Browser Connected: http://127.0.0.1:8000/
[I 250127 11:29:26 watcher:104] Running task: build (delay: None)
[sphinx-autobuild] Detected change: /removed/crate-docs-theme/docs/.crate-docs/.venv/lib64/python3.12/site-packages/dbfread/exceptions.py
[sphinx-autobuild] > sphinx-build -n -W /removed/crate-docs-theme/docs /removed/crate-docs-theme/docs/.crate-docs/.build
Running Sphinx v7.1.2
...

If I stop it and restart with make dev without resetting it first, it doesn't do that. Not sure what and why, any ideas?

Copy link
Collaborator

@msbt msbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but check #571 (comment) before merging

@msbt
Copy link
Collaborator

msbt commented Jan 27, 2025

Ok the error above seems unrelated to the node version, just reverted to main to add some css, so this is a different thing.

@amotl
Copy link
Member Author

amotl commented Jan 27, 2025

Thanks for your report. The loop feels like it is a flaw in sphinx-autobuild I may have observed the other day already.

@amotl amotl merged commit 7ec0a6c into main Jan 27, 2025
8 checks passed
@amotl amotl deleted the node22 branch January 27, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants