Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbox/CI: Update to Node.js 18 #365

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Sandbox/CI: Update to Node.js 18 #365

merged 1 commit into from
Dec 12, 2022

Conversation

amotl
Copy link
Member

@amotl amotl commented Dec 12, 2022

What the title says.

@amotl amotl changed the title Sandbox: Update to Node.js 18 Sandbox/CI: Update to Node.js 18 Dec 12, 2022
Base automatically changed from amo/modernize to main December 12, 2022 14:54
@amotl
Copy link
Member Author

amotl commented Dec 12, 2022

At crate/crate-admin#797, we observed switching to Node.js 18 introduced some slowness on CI/GHA. Let's check how it is going on behalf of this repository.

So, while indeed it is also bit slower here, I think it is acceptable.

@amotl amotl marked this pull request as ready for review December 12, 2022 15:02
@amotl amotl merged commit bfc4248 into main Dec 12, 2022
@amotl amotl deleted the amo/nodejs-18 branch December 12, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants