Enable caching for uv #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Dec 5, 2024
| with: | ||
| enable-cache: true | ||
| cache-dependency-glob: "requirements*.txt" | ||
| cache-suffix: ${{ matrix.python-version }} |
There was a problem hiding this comment.
Needed to prevent collision between the two jobs.
zanieb
commented
Dec 5, 2024
| @@ -80,6 +80,10 @@ jobs: | |||
|
|
|||
| - name: Set up uv | |||
| uses: astral-sh/setup-uv@v4 | |||
| with: | |||
| enable-cache: true | |||
| cache-dependency-glob: "requirements*.txt" | |||
There was a problem hiding this comment.
The default is uv.lock
|
Ah did you fix the build time by using a newer pandas version? |
amotl
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Ah did you fix the build time by using a newer pandas version?
Yes, that fixed it, but I still appreciate your patch, because it excellently expands our toolbox to know how to configure astral-sh/setup-uv properly, including package caching. Thank you very much. 🍀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
Enables storing the uv cache in GitHub Action's cache. This reduces the CI setup time from >8m to <2m. An example run can be seen here.
Most of the time was spent building pandas from source, ref #36 — uv's cache will include the built wheel.
edit: This appears to no longer be slow on
main, perhaps not worth it?