-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dictgen): Add aho-corasick support #1199
Conversation
Pull Request Test Coverage Report for Build 12560549722Details
💛 - Coveralls |
74d9cdb
to
9e5d85a
Compare
Yeah building a DFA is extremely costly. Did you try using the contiguous NFA? Likely slower search times, but potentially much faster construction time. (I have high hopes some day for adding support for serializing Aho-Corasick automata and then providing zero-copy deserialization APIs like what |
Also, what are you using to produce those benchmark results? It looks nice! |
If its too much slower, then I might as well use PHF so unsure if its worth trying.
https://crates.io/crates/divan It can still be jittery but appreciate the faster run time and the clean API. |
As recommended by @BurntSushi
Considering we should have millions of misses with only a couple of hits, this seems promising. However, the construction time is prohibitive.