SharpAc: Add support for model A903, and improve IRac fan & power control.
#1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new model `A903` * Minor tweaks for this model * Unit test coverage. * Should allow power control of this model now. * Fix typo * Adjust old suggested model for supported devices. For #1387
* Hopefully fix power control via `IRac` class * A903 appears to be near identical to A705 model. Make appropriate changes * Update unit tests accordingly. * Update supported model info. For #1387
* Enable `convertFan()` to report the correct fan speed when passed model info. Ref: #1387 (comment)
NiKiZe
approved these changes
Jan 22, 2021
crankyoldgit
added a commit
that referenced
this pull request
Feb 12, 2021
_v2.7.15 (20210213)_ **[BREAKING CHANGES]** - Some Daikin2 constants have been changed. (#1393) **[Features]** - Experimental basic support for EcoClim 56 & 15 bit protocols. (#1397 #1410) - MITSUBISHI_AC: Add support for enabling Weekly Timer. (#1403 #1404) - Mitsubishi ACs: Improve handling swing/vane settings. (#1399 #1401) - MITSUBISHI_AC: Add support for half degrees. (#1398 #1400) - Add `irutils::addSwing[V|H]ToString()` and adjust some constants (#1365 #1393) - SharpAc: Add support for model A903, and improve `IRac` fan & power control. (#1387 #1390) - Experimental support for Milestag2 (#1360 #1380) **[Misc]** - Improve `IRac::sendAc()` documentation. (#1408 #1409) - refactor ir_Transcold (#1407) - refactor ir_Toshiba (#1395) - Fix Travis-CI build issues. (#1396) - refactor ir_Teco (#1392) - Fujitsu A/C: Add warning/suggestions for AR-RAH1U devices (#1376 #1386) - refactor ir_Technibel (#1385) - Add the new logo and banner 🎉 (#1371 #1372) - Update references to sbprojects website. (#1381 #1383) - refactor ir_Tcl (#1379)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Feb 13, 2021
_v2.7.15 (20210213)_ **[BREAKING CHANGES]** - Some Daikin2 constants have been changed. (#1393) **[Features]** - Experimental basic support for EcoClim 56 & 15 bit protocols. (#1397 #1410) - MITSUBISHI_AC: Add support for enabling Weekly Timer. (#1403 #1404) - Mitsubishi ACs: Improve handling swing/vane settings. (#1399 #1401) - MITSUBISHI_AC: Add support for half degrees. (#1398 #1400) - Add `irutils::addSwing[V|H]ToString()` and adjust some constants (#1365 #1393) - SharpAc: Add support for model A903, and improve `IRac` fan & power control. (#1387 #1390) - Experimental support for Milestag2 (#1360 #1380) **[Misc]** - Improve `IRac::sendAc()` documentation. (#1408 #1409) - refactor ir_Transcold (#1407) - refactor ir_Toshiba (#1395) - Fix Travis-CI build issues. (#1396) - refactor ir_Teco (#1392) - Fujitsu A/C: Add warning/suggestions for AR-RAH1U devices (#1376 #1386) - refactor ir_Technibel (#1385) - Add the new logo and banner 🎉 (#1371 #1372) - Update references to sbprojects website. (#1381 #1383) - refactor ir_Tcl (#1379)
crankyoldgit
added a commit
that referenced
this pull request
Feb 13, 2021
##_v2.7.15 (20210213)_ **[BREAKING CHANGES]** - Some Daikin2 constants have been changed. (#1393) **[Features]** - Experimental basic support for EcoClim 56 & 15 bit protocols. (#1397 #1410) - MITSUBISHI_AC: Add support for enabling Weekly Timer. (#1403 #1404) - Mitsubishi ACs: Improve handling swing/vane settings. (#1399 #1401) - MITSUBISHI_AC: Add support for half degrees. (#1398 #1400) - Add `irutils::addSwing[V|H]ToString()` and adjust some constants (#1365 #1393) - SharpAc: Add support for model A903, and improve `IRac` fan & power control. (#1387 #1390) - Experimental support for Milestag2 (#1360 #1380) **[Misc]** - Improve `IRac::sendAc()` documentation. (#1408 #1409) - refactor ir_Transcold (#1407) - refactor ir_Toshiba (#1395) - Fix Travis-CI build issues. (#1396) - refactor ir_Teco (#1392) - Fujitsu A/C: Add warning/suggestions for AR-RAH1U devices (#1376 #1386) - refactor ir_Technibel (#1385) - Add the new logo and banner 🎉 (#1371 #1372) - Update references to sbprojects website. (#1381 #1383) - refactor ir_Tcl (#1379)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A903A903appears to be near identical toA705model. Make appropriate changesIRacpower control of Sharp.IRSharpAc::convertFan()to report the correct fan speed when passed model info.Power control (and model detection) confirmed working by users.
Fixes #1387