Fix implementation of getIsTransparent #12571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Imagine 1.3.0 introduced a change to how alpha channels are handled in versions of Imagick < 7. When we updated to use Imagine ~1.3.3.1 we started pulling in that version which had adverse effects on the
Raster::getIsTransparent()function.Previously that function returned if there was an alpha channel present or not, which wasn't necessarily an indication of if the image was actually transparent or not. For example, Imagine will apply an alpha layer to images when they are rotated with a background color that has an alpha. That alpha layer may not be used, but it is present.
Thanks to the help of the library authors this replaces the
getIsTransparentcheck with something more reliable.Related issues
Fixes #12565