Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for setting diagonal values for covariance matrices #755

Merged
merged 1 commit into from
May 20, 2022

Conversation

ayrton04
Copy link
Collaborator

I've been meaning to do this for years. Should make config files less ugly.

@SteveMacenski
Copy link
Collaborator

i don't disagree that this would be easier to read, but this seems late in the game for such a big change to folk's configuration files migrating between distributions. If this was something that we were super interested in re-architecting / fixing up for the next 10+ years of use, I agree refreshes would be nice. But I thought R_L was in a 'don't fix what ain't broke' phase and looking forward to something like Fuse?

@ayrton04
Copy link
Collaborator Author

Both are supported. I haven't removed support for loading the full matrix.

And yes, we'll get to porting fuse next. I just want to clean a few things up here before I tie it off.

@SteveMacenski
Copy link
Collaborator

SteveMacenski commented May 12, 2022

OK! I just saw the defaults change in the example files, but LGTM. If its both, then no problemo

@ayrton04 ayrton04 merged commit a8b92e9 into ros2 May 20, 2022
@ayrton04 ayrton04 deleted the diagonal-process-noise branch May 20, 2022 09:22
@djaniel
Copy link

djaniel commented Jun 12, 2023

Hi,
I have been doing some tests with robot localization. I installed robot localization using apt and I was getting an error related to this Issue. I checked and noticed that the commit that solves this issue is on branch ros2, but not in branch humble-devel (the one provided by apt).

@ayrton04
Copy link
Collaborator Author

This isn't an issue; it was a new feature. What error did you get?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants