Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce language requirement for constexpr BID conversions #739

Merged
merged 7 commits into from
Sep 30, 2024

Conversation

mborland
Copy link
Member

Closes: #737

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.2%. Comparing base (6e237c6) to head (71fe572).
Report is 14 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #739     +/-   ##
=========================================
- Coverage     99.2%   99.2%   -0.0%     
=========================================
  Files          226     226             
  Lines        16635   16609     -26     
  Branches      1792    1792             
=========================================
- Hits         16491   16464     -27     
- Misses         144     145      +1     
Files with missing lines Coverage Δ
include/boost/decimal/bid_conversion.hpp 100.0% <100.0%> (ø)
include/boost/decimal/decimal128.hpp 98.1% <ø> (ø)
include/boost/decimal/decimal32.hpp 98.8% <ø> (ø)
include/boost/decimal/decimal64.hpp 99.3% <ø> (ø)
test/test_bid_conversions.cpp 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e237c6...71fe572. Read the comment docs.

@mborland mborland merged commit 1b49d85 into develop Sep 30, 2024
65 checks passed
@mborland mborland deleted the simplify_bid branch September 30, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BID conversions should not need C++20
1 participant