Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 128 bit comparisons #709

Merged
merged 7 commits into from
Jul 11, 2024
Merged

Improve 128 bit comparisons #709

merged 7 commits into from
Jul 11, 2024

Conversation

mborland
Copy link
Member

Closes: #701
Closes: #707
Closes: #708

New benchmarks for decimal128 show >20% speedup and decimal128_fast nets ~30%

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.1%. Comparing base (80872c3) to head (2b0cce3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #709     +/-   ##
=========================================
- Coverage     99.2%   99.1%   -0.0%     
=========================================
  Files          230     230             
  Lines        16337   16339      +2     
  Branches      1765    1766      +1     
=========================================
- Hits         16191   16190      -1     
- Misses         146     149      +3     
Files Coverage Δ
include/boost/decimal/decimal128.hpp 98.1% <100.0%> (-<0.1%) ⬇️
include/boost/decimal/decimal128_fast.hpp 97.6% <100.0%> (+0.1%) ⬆️
include/boost/decimal/detail/comparison.hpp 100.0% <ø> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80872c3...2b0cce3. Read the comment docs.

@mborland mborland merged commit 43c44e6 into develop Jul 11, 2024
64 checks passed
@mborland mborland deleted the comp_128 branch July 11, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant