Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better 64 bit comparisons #705

Merged
merged 13 commits into from
Jul 11, 2024
Merged

Better 64 bit comparisons #705

merged 13 commits into from
Jul 11, 2024

Conversation

mborland
Copy link
Member

Closes: #704

Knocks decimal64 down to 0.825 and ~parity for decimal64_fast

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.2%. Comparing base (c115908) to head (0d04df2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #705     +/-   ##
=========================================
- Coverage     99.2%   99.2%   -0.0%     
=========================================
  Files          230     230             
  Lines        16309   16337     +28     
  Branches      1767    1765      -2     
=========================================
+ Hits         16164   16191     +27     
- Misses         145     146      +1     
Files Coverage Δ
include/boost/decimal/charconv.hpp 95.3% <100.0%> (+0.1%) ⬆️
include/boost/decimal/decimal32.hpp 99.8% <ø> (ø)
include/boost/decimal/decimal32_fast.hpp 96.7% <100.0%> (-0.3%) ⬇️
include/boost/decimal/decimal64.hpp 99.3% <100.0%> (-<0.1%) ⬇️
include/boost/decimal/decimal64_fast.hpp 98.6% <100.0%> (+0.1%) ⬆️
include/boost/decimal/detail/comparison.hpp 100.0% <100.0%> (ø)
test/test_cmath.cpp 100.0% <100.0%> (ø)
test/test_to_chars.cpp 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c115908...0d04df2. Read the comment docs.

@mborland mborland merged commit 80872c3 into develop Jul 11, 2024
64 checks passed
@mborland mborland deleted the comp_64 branch July 11, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve 64-bit comparisions
1 participant