Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to decimal64_fast #644

Merged
merged 19 commits into from
Jun 13, 2024
Merged

Improvements to decimal64_fast #644

merged 19 commits into from
Jun 13, 2024

Conversation

mborland
Copy link
Member

Normalize the values in the constructor and remove all the calls to normalize in the basis functions

Closes #639

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.6%. Comparing base (b4b08c2) to head (4e0b209).
Report is 12 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #644     +/-   ##
=========================================
- Coverage     98.7%   98.6%   -0.0%     
=========================================
  Files          219     219             
  Lines        15717   15636     -81     
  Branches      1720    1719      -1     
=========================================
- Hits         15497   15414     -83     
- Misses         220     222      +2     
Files Coverage Δ
include/boost/decimal/decimal64_fast.hpp 98.4% <100.0%> (-0.7%) ⬇️
include/boost/decimal/detail/add_impl.hpp 100.0% <100.0%> (ø)
test/test_decimal64_fast_basis.cpp 100.0% <100.0%> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4b08c2...4e0b209. Read the comment docs.

@mborland mborland merged commit 00cd5ea into develop Jun 13, 2024
62 checks passed
@mborland mborland deleted the dec64_faster branch June 13, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize decimal64_fast values in the constructor
1 participant