Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comparison functions #598

Merged
merged 4 commits into from
May 27, 2024
Merged

Improve comparison functions #598

merged 4 commits into from
May 27, 2024

Conversation

mborland
Copy link
Member

@mborland mborland commented May 24, 2024

Closes: #596
Closes: #591

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.1%. Comparing base (93d13a9) to head (dc2b4ac).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #598     +/-   ##
=========================================
- Coverage     99.1%   99.1%   -0.0%     
=========================================
  Files          204     204             
  Lines        13343   13342      -1     
  Branches      1514    1511      -3     
=========================================
- Hits         13218   13217      -1     
  Misses         125     125             
Files Coverage Δ
include/boost/decimal/decimal128.hpp 97.2% <100.0%> (-<0.1%) ⬇️
include/boost/decimal/decimal32.hpp 99.6% <100.0%> (-<0.1%) ⬇️
include/boost/decimal/decimal64.hpp 99.0% <100.0%> (-<0.1%) ⬇️
include/boost/decimal/detail/comparison.hpp 100.0% <100.0%> (ø)
...lude/boost/decimal/detail/integer_search_trees.hpp 100.0% <100.0%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93d13a9...dc2b4ac. Read the comment docs.

@mborland mborland merged commit 3c9c591 into develop May 27, 2024
66 checks passed
@mborland mborland deleted the better_comp branch May 27, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce complexity of comparisons Add function to shrink and normalize at the same time
1 participant