Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atanh skeleton impl and test #330

Merged
merged 7 commits into from
Nov 18, 2023
Merged

atanh skeleton impl and test #330

merged 7 commits into from
Nov 18, 2023

Conversation

ckormanyos
Copy link
Collaborator

No description provided.

@ckormanyos
Copy link
Collaborator Author

This one still needs tests of edge cases, small argument and of course to reach $100$ percent coverage in the atanh() implementation.

@ckormanyos
Copy link
Collaborator Author

Hi Matt (@mborland) new in today's lineup is the bare-metal CI run, which checks code size and functionality as discussed in another thread. If you get a chance, could you please add the QEMU metal run to the required runs in branch-protection? See image below for naming.

grafik

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #330 (952c096) into develop (422e385) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #330     +/-   ##
=========================================
+ Coverage     97.7%   97.7%   +0.1%     
=========================================
  Files           72      73      +1     
  Lines         3275    3295     +20     
=========================================
+ Hits          3199    3219     +20     
  Misses          76      76             
Files Coverage Δ
include/boost/decimal/cmath.hpp 100.0% <ø> (ø)
include/boost/decimal/detail/cmath/asinh.hpp 100.0% <ø> (ø)
include/boost/decimal/detail/cmath/atanh.hpp 100.0% <100.0%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 422e385...952c096. Read the comment docs.

@mborland
Copy link
Member

Hi Matt (@mborland) new in today's lineup is the bare-metal CI run, which checks code size and functionality as discussed in another thread. If you get a chance, could you please add the QEMU metal run to the required runs in branch-protection? See image below for naming.

grafik

Done

@ckormanyos
Copy link
Collaborator Author

CI failing also resulting from Math 1052.

@ckormanyos ckormanyos merged commit 4a89f35 into develop Nov 18, 2023
@ckormanyos ckormanyos deleted the atanh branch November 18, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants