Update curl to 7.74.0, libssh2 to 1.9.0, libs3 to match. #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbsheth
reviewed
Jan 4, 2021
cmake/configs/default.cmake
Outdated
| @@ -46,7 +46,7 @@ hunter_default_version(BoringSSL VERSION 0.0.0-0f5ecd3a8-p0) | |||
| hunter_default_version(Box2D VERSION 2.3.1-p0) | |||
| hunter_default_version(CLAPACK VERSION 3.2.1) | |||
| hunter_default_version(CLI11 VERSION 1.8.0) | |||
| hunter_default_version(CURL VERSION 7.60.0-p2) | |||
| hunter_default_version(CURL VERSION 7.74.0-p0) | |||
There was a problem hiding this comment.
These versions don't exist yet - please add them to the hunter.cmake files for each project.
|
@ned14 Looks like curl and s3 failed all tests - can you check on them? |
2cb4875 to
8155b4d
Compare
42da327 to
503785c
Compare
|
@ned14 Can you restore the libs3 change and I will merge. Thanks! |
rbsheth
reviewed
Feb 8, 2021
rbsheth
reviewed
Mar 1, 2021
|
@ned14 Merged and released: https://github.com/cpp-pm/curl/releases/tag/v7.74.0-p1 |
rbsheth
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've followed this guide
step by step carefully. Yes
I've checked this Git style guide. Yes
I've checked this CMake style guide. Yes
My change will work with CMake 3.2 (minimum requirement for Hunter). Yes
I will try to keep this pull request as small as possible and will try not to mix unrelated features. Yes
Note that some of the build matrix has been disabled, as upstream OpenSSL dependency doesn't work with them.