-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inputs #4
Add inputs #4
Conversation
Hi Brendan, your PR looks amazing! I tried to run
I would love to learn from you how to pass parameters to run_checks.sh, thank you. |
The secret sauce is here in actions.yml: According to GH docs the You can probably better understand now why I had to make modifications to the Dockerfile. |
resolves #3
This adds 2 new inputs to the action:
style
can be set to any of the values that clang-format accepts.extensions
a comma seperated list of file extensions for which to focus on. I added this one because I noticed the action was running clang-tidy/format on all changed files in the PR (which obviously resulted in more annoying failures and longer bot comments).I can explain how the input args get passed to the run_checks.sh if needed.
I have also updated the Readme about the user inputs and required GH secrets token
demo now lives here
I added a basic workflow using the action to test on a drafted PR since push events always fail with this action.