update workflows and unit tests #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 87.71% 95.92% +8.20%
==========================================
Files 4 7 +3
Lines 171 270 +99
==========================================
+ Hits 150 259 +109
+ Misses 21 11 -10 ☔ View full report in Codecov by Sentry. |
We should have picked up on this earlier. Last report was uploaded for 848711e. I don't know why it stopped uploading coverage reports, but this PR seems to fix that now. |
3d1b2e2 to
389bb37
Compare
389bb37 to
8fe0dcb
Compare
now uses the following reusable workflows: - pre-commit.yml - py-coverage.yml ## Adjusting Unit tests - codecov-action v4 now requires a CODECOV token (which I added to repo secrets) - `test_download_file` was passing unexpectedly (should have expectedly failed for `"latest"` release_tag). - `test_path_warning` wouldn't pass when run in a venv (which is how I run tests locally). - `test_get_sha` was using outdated sha512sum for Windows. - CI now runs unit tests on all 3 OS and the reusable workflow will combine coverage data for the coverage reports.
makes better use of stubs in the same file
uses ruff for linting and formatting in a pre-commit hook also ran ruff on all python files for correctness
now includes test code in coverage does not download every supported version just to trigger lines in coverage data; only 1 version will suffice. only download clang-format when testing `install_tool()` because it gets same coverage and downloads faster on all supported platforms.
8fe0dcb to
447dc6e
Compare
|
shenxianpeng
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now uses the following reusable workflows:
Adjusting Unit tests
test_download_filewas passing unexpectedly (should have expectedly failed for"latest"release_tag).test_path_warningwouldn't pass when run in a venv (which is how I run tests locally).test_get_shawas using outdated sha512sum for Windows.test_install_toolsdoes not need to download every supported version of clang-tidy and clang-format. By only downloading v12 of clang-format, we get the same coverage and faster test runtime across all platforms. Note: the CI has a separate job matrix to install and invoke all supported versions of clang-tidy and clang-format.test_is_installedto trigger lines that surmount to "tool is not installed" condition. This is just done to improve code coverage.pre-commit