-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated classifier with licence expression (PEP 639) #110
base: main
Are you sure you want to change the base?
Conversation
|
WalkthroughThis pull request updates the project metadata in the Changes
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pyproject.toml
(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Test
pyproject.toml
[error] 1-1: invalid pyproject.toml config: project.license
. configuration error: project.license
must be valid exactly by one definition (2 matches found): - keys: 'file': {type: string} required: ['file'] - keys: 'text': {type: string} required: ['text']
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Codacy Static Code Analysis
license = "MIT" | ||
license-files = [ "LICENSE" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Critical Issue: Invalid project.license
Format Causing Schema Validation Error
The new change sets the license as a bare string (license = "MIT"
). However, the pipeline error indicates that the schema expects the project.license
field to be unambiguously defined as a table—with either a "text"
key or a "file"
key—not as a plain string. To resolve this conflict, please update the license declaration to a table format. For example, the diff below would address the issue:
-license = "MIT"
+license = { text = "MIT" }
The accompanying license-files
entry (line 11) is acceptable if you intend to signal where the license file is located.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
license = "MIT" | |
license-files = [ "LICENSE" ] | |
license = { text = "MIT" } | |
license-files = [ "LICENSE" ] |
Same as cpp-linter/cpp-linter#136
Summary by CodeRabbit