Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cozy-flags: Improve imports/exports #1272

Open
Crash-- opened this issue Mar 5, 2021 · 0 comments
Open

cozy-flags: Improve imports/exports #1272

Crash-- opened this issue Mar 5, 2021 · 0 comments

Comments

@Crash--
Copy link
Contributor

Crash-- commented Mar 5, 2021

comments from @ptbrowne :

In the node file (index.js), I think we could
remove the typeof window !== undefined block, this way we have no conditional require
without conditional require, we can use import/export instead of require/module.exports in both files.
If not possible, LGTM
@ptbrowne ptbrowne changed the title cozy-flags cozy-flags: Improve imports/exports Mar 5, 2021
paultranvan added a commit that referenced this issue Mar 5, 2021
@paultranvan
fix: Remove useless block for node
cb506f1 
See #1272
@paultranvan paultranvan mentioned this issue Mar 5, 2021
Merged
paultranvan added a commit that referenced this issue Mar 8, 2021
@paultranvan
fix: Remove useless block for node
fb15094 
See #1272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Crash--