Improve errors during login #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now determine and use cozyUrl in home.component, and also in login component. Instead of calculating it multiple times, let's pass it from home to login.
To know where we log in
Also refactored a little the CozySanitizeUrlService.
82ae055 to
c63307f
Compare
Merkur39
approved these changes
Nov 15, 2024
Comment on lines
+41
to
+43
| if (inputUrl.includes("@")) { | ||
| throw new Error("noEmailAsCozyUrl"); | ||
| } |
There was a problem hiding this comment.
Il n'est pas possible d'avoir d'arobase dans le nom d'un Cozy ?
Sinon une regex serait plus sûr (/^[^\s@]+@[^\s@]+\.[^\s@]+$/)
There was a problem hiding this comment.
J'imagine que non. J'avoue que j'ai juste déplacé sans chercher à remettre en question ici.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.