Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last fixes #304

Merged
merged 2 commits into from
Oct 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/browser/src/_locales/en/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -4615,6 +4615,9 @@
"empty_address": {
"message": "No address found"
},
"empty_jobTitle": {
"message": "No job title"
},
"new_address": {
"message": "New address"
},
Expand All @@ -4627,6 +4630,9 @@
"new_name": {
"message": "New name"
},
"new_jobTitle": {
"message": "New job title"
},
"new_paperIdentityCardNumber": {
"message": "New national ID card number"
},
Expand Down
6 changes: 6 additions & 0 deletions apps/browser/src/_locales/fr/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -4630,6 +4630,9 @@
"empty_address": {
"message": "Aucune adresse enregistrée"
},
"empty_jobTitle": {
"message": "Aucune profession"
},
"new_address": {
"message": "Nouvelle adresse"
},
Expand All @@ -4642,6 +4645,9 @@
"new_name": {
"message": "Nouveau nom"
},
"new_jobTitle": {
"message": "Nouvelle profession"
},
"new_paperIdentityCardNumber": {
"message": "Nouveau numéro de carte d'identité"
},
Expand Down
9 changes: 9 additions & 0 deletions apps/browser/src/autofill/background/overlay.background.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1028,6 +1028,13 @@ export class OverlayBackground implements OverlayBackgroundInterface {
fieldHtmlIDToFill,
});
} else {
// Special case: if we are a paper and there are no ambiguous fields, we arrive here
// and we do not want to show the empty list
if (isPaperAttributesModel(focusedFieldModel) && shouldHideHealthPaper) {
this.fillInlineMenuCipher(message, port);
return;
}

const value = await getCozyValue({
client,
cipher,
Expand Down Expand Up @@ -1701,6 +1708,7 @@ export class OverlayBackground implements OverlayBackgroundInterface {
empty_phone: this.i18nService.translate("empty_phone"),
empty_address: this.i18nService.translate("empty_address"),
empty_name: this.i18nService.translate("empty_name"),
empty_jobTitle: this.i18nService.translate("empty_jobTitle"),
new: this.i18nService.translate("new"),
address: this.i18nService.translate("address"),
address_street: this.i18nService.translate("address_street"),
Expand Down Expand Up @@ -1729,6 +1737,7 @@ export class OverlayBackground implements OverlayBackgroundInterface {
new_phone: this.i18nService.translate("new_phone"),
new_email: this.i18nService.translate("new_email"),
new_name: this.i18nService.translate("new_name"),
new_jobTitle: this.i18nService.translate("new_jobTitle"),
new_contact: this.i18nService.translate("new_contact"),
addressDetails: this.i18nService.translate("addressDetails"),
new_paperIdentityCardNumber: this.i18nService.translate("new_paperIdentityCardNumber"),
Expand Down
Loading