Bug fixes on paper notification

apps/browser/src/_locales/en/messages.json

@@ -980,7 +980,13 @@
     "description": "Clipboard is the operating system thing where you copy/paste data to on your device."
   },
   "notificationPaperSavedDesc": {
-    "message": "A new document with the information entered has just been added to your Cozy's My Papers application."
+    "message": "A new $VALUE$ document with the information entered has just been added to your Cozy's My Papers application.",
+    "placeholders": {
+      "value": {
+        "content": "$1",
+        "example": "Identity card"
+      }
+    }
   },
   "notificationPaperSavedUnderstood": {
     "message": "Understood"

apps/browser/src/_locales/fr/messages.json

@@ -980,7 +980,13 @@
     "description": "Clipboard is the operating system thing where you copy/paste data to on your device."
   },
   "notificationPaperSavedDesc": {
-    "message": "Un nouveau document avec l'information saisie vient d'être ajouté dans l'application Mes Papiers de votre Cozy."
+    "message": "Un nouveau document $VALUE$ avec l'information saisie vient d'être ajouté dans l'application Mes Papiers de votre Cozy.",
+    "placeholders": {
+      "value": {
+        "content": "$1",
+        "example": "Carte d'identité"
+      }
+    }
   },
   "notificationPaperSavedUnderstood": {
     "message": "J'ai compris"

apps/browser/src/autofill/background/abstractions/notification.background.ts

@@ -18,6 +18,7 @@ interface AddPaperSavedQueueMessage extends NotificationQueueMessage {
   type: "paper-saved";
   paperSavedId: string;
   paperSavedQualification: string;
+  paperSavedQualificationLabel: string;
 }
 // Cozy customization end;
 

apps/browser/src/autofill/background/notification.background.ts

@@ -205,6 +205,8 @@ export default class NotificationBackground {
       case NotificationQueueMessageType.PaperSaved:
         typeData.paperSavedId = notificationQueueMessage.paperSavedId;
         typeData.paperSavedQualification = notificationQueueMessage.paperSavedQualification;
+        typeData.paperSavedQualificationLabel =
+          notificationQueueMessage.paperSavedQualificationLabel;
         break;
       // Cozy customization end;
       case NotificationQueueMessageType.AddLogin:
@@ -413,6 +415,7 @@ export default class NotificationBackground {
       wasVaultLocked: false,
       paperSavedId: options.paperSavedId,
       paperSavedQualification: options.paperSavedQualification,
+      paperSavedQualificationLabel: options.paperSavedQualificationLabel,
     };
     await this.sendNotificationQueueMessage(tab, message);
   }

apps/browser/src/autofill/background/overlay.background.ts

@@ -69,10 +69,9 @@ import {
 
 /* start Cozy imports */
 /* eslint-disable */
-import { Q } from "cozy-client";
+import { Q, models } from "cozy-client";
 import { IOCozyContact } from "cozy-client/types/types";
 // @ts-ignore
-import { CONTACTS_DOCTYPE } from "cozy-client/dist/models/contact";
 import { nameToColor } from "cozy-ui/transpiled/react/Avatar/helpers";
 import { CozyClientService } from "../../popup/services/cozyClient.service";
 import { AmbiguousContactFieldName, AmbiguousContactFieldValue } from "src/autofill/types";
@@ -85,6 +84,11 @@ import {
   cleanFormattedAddress,
 } from "../../../../../libs/cozy/contact.helper";
 import NotificationBackground from "./notification.background";
+import { CONTACTS_DOCTYPE, FILES_DOCTYPE } from "../../../../../libs/cozy/constants";
+
+const {
+  document: { locales },
+} = models;
 /* eslint-enable */
 /* end Cozy imports */
 
@@ -1052,10 +1056,18 @@ export class OverlayBackground implements OverlayBackgroundInterface {
         logService: this.logService,
       });
 
-      await this.notificationBackground.paperSaved(port.sender.tab, {
-        paperSavedId: createdOrUpdatedCozyDoctype._id,
-        paperSavedQualification: createdOrUpdatedCozyDoctype.metadata.qualification.label,
-      });
+      if (createdOrUpdatedCozyDoctype._type === FILES_DOCTYPE) {
+        const locale = this.i18nService.translationLocale || "en";
+        const t = locales.getBoundT(locale);
+
+        await this.notificationBackground.paperSaved(port.sender.tab, {
+          paperSavedId: createdOrUpdatedCozyDoctype._id,
+          paperSavedQualification: createdOrUpdatedCozyDoctype.metadata.qualification.label,
+          paperSavedQualificationLabel: t(
+            `Scan.items.${createdOrUpdatedCozyDoctype.metadata.qualification.label}`,
+          ),
+        });
+      }
 
       const isAddress = inputValues.values.some((inputValue) => inputValue.key === "street");
       // If is an address, we need set the value of the field to the formatted address, because getCozyValue refers to `formattedAddress` to return values corresponding to the postal address.

apps/browser/src/autofill/content/notification-bar.ts

@@ -841,6 +841,7 @@ async function loadNotificationBar() {
       importType: typeData.importType,
       paperSavedId: typeData.paperSavedId,
       paperSavedQualification: typeData.paperSavedQualification,
+      paperSavedQualificationLabel: typeData.paperSavedQualificationLabel,
     };
     const notificationBarUrl = "notification/bar.html";
 

apps/browser/src/autofill/notification/abstractions/notification-bar.ts

@@ -6,6 +6,7 @@ type NotificationBarIframeInitData = {
   importType?: string;
   paperSavedId?: string;
   paperSavedQualification?: string;
+  paperSavedQualificationLabel?: string;
 };
 
 type NotificationBarWindowMessage = {

apps/browser/src/autofill/notification/bar.ts

@@ -47,7 +47,10 @@ function initNotificationBar(message: NotificationBarWindowMessage) {
     never: chrome.i18n.getMessage("never"),
     folder: chrome.i18n.getMessage("folder"),
     // Cozy customization; paper saved notification
-    notificationPaperSavedDesc: chrome.i18n.getMessage("notificationPaperSavedDesc"),
+    notificationPaperSavedDesc: chrome.i18n.getMessage(
+      "notificationPaperSavedDesc",
+      notificationBarIframeInitData.paperSavedQualificationLabel,
+    ),
     notificationPaperSavedUnderstood: chrome.i18n.getMessage("notificationPaperSavedUnderstood"),
     notificationPaperSavedSee: chrome.i18n.getMessage("notificationPaperSavedSee"),
     // Cozy customization end;

apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts

@@ -864,7 +864,7 @@ export class AutofillInlineMenuList extends AutofillInlineMenuPageElement {
     radio.setAttribute("type", "radio");
     radio.setAttribute("name", "contact");
     radio.setAttribute("id", "contact");
-    radio.style.marginRight = "2rem";
+    radio.classList.add("fill-cipher-contact-radio");
 
     const detailsSpan = document.createElement("span");
     detailsSpan.classList.add("cipher-details");

apps/browser/src/vault/popup/components/vault/current-tab.component.ts

@@ -262,7 +262,10 @@ export class CurrentTabComponent implements OnInit, OnDestroy {
       // Cozy customization; send doAutoFill to background because
       // doAutoFill needs a Cozy Client store with all the contacts
       // and only the background Cozy Client store has them on Manifest V3
-      if (cipher.type === CipherType.Contact && BrowserApi.isManifestVersion(3)) {
+      if (
+        (cipher.type === CipherType.Contact || cipher.type === CipherType.Paper) &&
+        BrowserApi.isManifestVersion(3)
+      ) {
         this.messageSender.send("doAutoFill", {
           autofillOptions: {
             tab: this.tab,

apps/browser/src/vault/popup/components/vault/vault-items.component.ts

@@ -461,7 +461,10 @@ export class VaultItemsComponent extends BaseVaultItemsComponent implements OnIn
       // Cozy customization; send doAutoFill to background because
       // doAutoFill needs a Cozy Client store with all the contacts
       // and only the background Cozy Client store has them on Manifest V3
-      if (cipher.type === CipherType.Contact && BrowserApi.isManifestVersion(3)) {
+      if (
+        (cipher.type === CipherType.Contact || cipher.type === CipherType.Paper) &&
+        BrowserApi.isManifestVersion(3)
+      ) {
         this.messageSender.send("doAutoFill", {
           autofillOptions: {
             cipher: cipher,

apps/browser/src/vault/popup/components/vault/view.component.ts

@@ -512,7 +512,10 @@ export class ViewComponent extends BaseViewComponent implements OnInit, OnDestro
       // Cozy customization; send doAutoFill to background because
       // doAutoFill needs a Cozy Client store with all the contacts
       // and only the background Cozy Client store has them on Manifest V3
-      if (this.cipher.type === CipherType.Contact && BrowserApi.isManifestVersion(3)) {
+      if (
+        (this.cipher.type === CipherType.Contact || this.cipher.type === CipherType.Paper) &&
+        BrowserApi.isManifestVersion(3)
+      ) {
         this.messageSender.send("doAutoFill", {
           autofillOptions: {
             tab: this.tab,