Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not need to click multiple times in page menu to display it #208

Merged
merged 1 commit into from
May 13, 2024

Conversation

zatteo
Copy link

@zatteo zatteo commented May 13, 2024

After a page load, we needed to click multiple times on the in page menu to display it. It was because we used "#contact-row-list" everywhere, except in one place where we used "#contacts-row-list" leading to errors.

After a page load, we needed to click multiple times on the inpage menu to display it. It was because we used "#contact-row-list" everywhere, except in one place where we used "#contacts-row-list" leading to errors.
Copy link
Member

@Ldoppea Ldoppea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, and sorry, was my fault 😓

@zatteo
Copy link
Author

zatteo commented May 13, 2024

Good catch, and sorry, was my fault 😓

Did not see it in review too 😢

@zatteo zatteo merged commit 99ae740 into feat/stream1 May 13, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the fix/show-inpagemenu-error branch May 13, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants