Order and wording fixes #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to display me as favorite so that it is available at first glance in the UI. We leverage the fact that the favorite field is not defined by default.
this page We have options in settings to disable showing cards and profiles/contacts types in "For this web page". When it was disabled it was showing an empty type component. Now it is showing nothing.
Ldoppea
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Invert order of contacts and profiles in current tab
fix: Migrate profile setting wording
fix: Show nothing in "For this web page" if a type is disabled for this page
fix: Sort paper by date was not working because missing creation date