Add an "I understand" button to profiles migration component #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
approved these changes
May 2, 2024
"I understand" translation will be used for another button, so let's change the key so that it is not related to where it is used.
When clicking on this button, the profile migration component button is hidden until the next logout/login. profilesMigrationHidden has been put in AccountProfile because it is cleaned after a logout.
account.settings is : - per user - kept after a logout So it will avoid two users to share the same profilesCleanDeadline.
f59eebb to
56f0705
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"I understand" button hide the profiles migration component until the next logout/login.
Also moved
profilesCleanDeadlinetoaccount.settingsso it will avoid two users to share the sameprofilesCleanDeadline.