Skip to content

Commit

Permalink
fix: Avoid suggestions blink when going to vault tab
Browse files Browse the repository at this point in the history
In vault tab, we can either see in the suggestion section :
- available suggestions
- no suggestion available with a button to create a login

But we could see a blink because we displayed the section *before* suggestions have been loaded.

So let's display suggestion section only when they have been loaded.
  • Loading branch information
zatteo committed Nov 7, 2024
1 parent 7d5a77a commit 8f79d7e
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ <h1 class="sr-only">{{ "myVault" | i18n }}</h1>
</ng-container>
</div>
<ng-container *ngIf="ciphers && ciphers.length && !showSearching()">
<div class="box list" *ngIf="ciphersForCurrentTab.length">
<div class="box list" *ngIf="ciphersForCurrentTab && ciphersForCurrentTab.length">
<h2 class="box-header">
{{ "suggestions" | i18n }}
</h2>
Expand All @@ -73,7 +73,7 @@ <h2 class="box-header">
</app-cipher-row>
</div>
</div>
<div class="box list" *ngIf="!ciphersForCurrentTab.length">
<div class="box list" *ngIf="ciphersForCurrentTab && !ciphersForCurrentTab.length">
<h2 class="box-header">
{{ "suggestions" | i18n }}
</h2>
Expand Down

0 comments on commit 8f79d7e

Please sign in to comment.