Skip to content

Commit

Permalink
fix: Prettier for DecisionArray code
Browse files Browse the repository at this point in the history
  • Loading branch information
zatteo committed May 3, 2024
1 parent 5254c6e commit 896d576
Show file tree
Hide file tree
Showing 3 changed files with 277 additions and 274 deletions.
7 changes: 5 additions & 2 deletions apps/browser/src/autofill/services/autofill.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ import { LoginUriView } from "@bitwarden/common/vault/models/view/login-uri.view

import { generateIdentityViewFromCipherView } from "../../../../../libs/cozy/contact.helper";
import { BrowserApi } from "../../browser/browserApi";
import { evaluateDecisionArray, makeDecisionArray } from "../../cozy/autofill/evaluateDecisionArray";
import {
evaluateDecisionArray,
makeDecisionArray,
} from "../../cozy/autofill/evaluateDecisionArray";
import { BrowserStateService } from "../../services/abstractions/browser-state.service";
import AutofillField from "../models/autofill-field";
import AutofillPageDetails from "../models/autofill-page-details";
Expand Down Expand Up @@ -700,7 +703,7 @@ export default class AutofillService implements AutofillServiceInterface {
break;
}

const decisionArray = makeDecisionArray(scriptContext)
const decisionArray = makeDecisionArray(scriptContext);
scriptContext.ambiguity = decisionArray.ambiguity;
scriptContext.decisionArray = decisionArray;
}
Expand Down
157 changes: 78 additions & 79 deletions apps/browser/src/cozy/autofill/evaluateDecisionArray.spec.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import { DecisionArray, evaluateDecisionArray } from "./evaluateDecisionArray"
import { DecisionArray, evaluateDecisionArray } from "./evaluateDecisionArray";

const makeAction = (decisionArray: DecisionArray) => {
return [
null,
null,
null,
{
decisionArray
}
]
}
decisionArray,
},
];
};

describe("Autofill Service", () => {
it("Extension is logged in, has an existing cipher for website, we are in a form that's not a search => We should display the menu (e.g. assurance retraite)", () => {
Expand All @@ -31,10 +31,10 @@ describe("Autofill Service", () => {
field_isInSignupForm: false,
hasMultipleScript: false,
field_visible: true,
field_viewable: true,
}
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)
})
field_viewable: true,
};
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);
});

it("We are in a search form => We should never display the menu", () => {
const decisionArray: DecisionArray = {
Expand All @@ -55,10 +55,10 @@ describe("Autofill Service", () => {
field_isInSignupForm: false,
hasMultipleScript: true,
field_visible: true,
field_viewable: true,
}
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(false)
})
field_viewable: true,
};
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(false);
});

it("Extension is logged in, has an existing cipher for website, we are NOT in a form but there are at least 2 Login fields => We should display menu (e.g. EDF)", () => {
const decisionArray: DecisionArray = {
Expand All @@ -80,9 +80,9 @@ describe("Autofill Service", () => {
hasMultipleScript: false,
field_visible: true, // SET
field_viewable: false,
}
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)
})
};
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);
});

it("Extension is logged in (or not), no ambiguity, there are at least 2 Card fields, we are in a form => We should display menu", () => {
const decisionArray: DecisionArray = {
Expand All @@ -104,14 +104,14 @@ describe("Autofill Service", () => {
hasMultipleScript: false,
field_visible: true,
field_viewable: false,
}
};

decisionArray.connected = true
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)
decisionArray.connected = false
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)
})
decisionArray.connected = true;
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);

decisionArray.connected = false;
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);
});

it("Extension is logged in (or not), ambiguity, but there are at least 4 Card fields, we are in a form => We should display menu", () => {
const decisionArray: DecisionArray = {
Expand All @@ -133,14 +133,14 @@ describe("Autofill Service", () => {
hasMultipleScript: false,
field_visible: true,
field_viewable: false,
}
};

decisionArray.connected = true;
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);

decisionArray.connected = true
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)

decisionArray.connected = false
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)
})
decisionArray.connected = false;
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);
});

it("Extension is logged in, there are at least 2 Identity fields, we are in a form => We should display menu (i.e. EDF account creation)", () => {
const decisionArray: DecisionArray = {
Expand All @@ -162,10 +162,10 @@ describe("Autofill Service", () => {
hasMultipleScript: false,
field_visible: true, // SET
field_viewable: false,
}
};

expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)
})
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);
});

it("Extension is logged in, there are at least 2 Contacts fields, we are in a form => We should display menu (i.e. EDF account creation)", () => {
const decisionArray: DecisionArray = {
Expand All @@ -187,10 +187,10 @@ describe("Autofill Service", () => {
hasMultipleScript: false,
field_visible: true, // SET
field_viewable: false,
}
};

expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)
})
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);
});

it("Extension is logged out, enough Login fields, we are in a login form (or not) => We should display the menu (i.e. login Cozy or Fnac)", () => {
const decisionArray: DecisionArray = {
Expand All @@ -212,14 +212,14 @@ describe("Autofill Service", () => {
hasMultipleScript: false,
field_visible: true,
field_viewable: false,
}
};

decisionArray.field_isInForm = true
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)
decisionArray.field_isInForm = false
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)
})
decisionArray.field_isInForm = true;
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);

decisionArray.field_isInForm = false;
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);
});

it("Extension is logged out, there is a generic login, we are in a signup form => We should display the menu (i.e. signup form CCM)", () => {
const decisionArray: DecisionArray = {
Expand All @@ -241,10 +241,10 @@ describe("Autofill Service", () => {
hasMultipleScript: false,
field_visible: true,
field_viewable: false,
}
};

expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)
})
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);
});

it("Extension is logged in (or not), no ambiguity, there are at least 2 Identiy fields => We should display menu (i.e. Netflix)", () => {
const decisionArray: DecisionArray = {
Expand All @@ -266,14 +266,14 @@ describe("Autofill Service", () => {
hasMultipleScript: false,
field_visible: true,
field_viewable: false,
}
};

decisionArray.connected = true;
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);

decisionArray.connected = true
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)

decisionArray.connected = false
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)
})
decisionArray.connected = false;
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);
});

it("Extension is logged in (or not), no ambiguity, there are at least 2 Contacts fields => We should display menu (i.e. Netflix)", () => {
const decisionArray: DecisionArray = {
Expand All @@ -295,14 +295,14 @@ describe("Autofill Service", () => {
hasMultipleScript: false,
field_visible: true,
field_viewable: false,
}
};

decisionArray.connected = true
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)
decisionArray.connected = false
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)
})
decisionArray.connected = true;
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);

decisionArray.connected = false;
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);
});

it("Extension is logged in (or not), with ambiguity, there are at least 3 Identiy fields => We should display menu (i.e. CCM)", () => {
const decisionArray: DecisionArray = {
Expand All @@ -324,14 +324,14 @@ describe("Autofill Service", () => {
hasMultipleScript: false,
field_visible: true,
field_viewable: false,
}
};

decisionArray.connected = true;
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);

decisionArray.connected = true
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)

decisionArray.connected = false
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)
})
decisionArray.connected = false;
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);
});

it("Extension is logged in (or not), with ambiguity, there are at least 3 Identiy fields => We should display menu (i.e. CCM)", () => {
const decisionArray: DecisionArray = {
Expand All @@ -353,14 +353,14 @@ describe("Autofill Service", () => {
hasMultipleScript: false,
field_visible: true,
field_viewable: false,
}
};

decisionArray.connected = true;
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);

decisionArray.connected = true
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)

decisionArray.connected = false
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true)
})
decisionArray.connected = false;
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(true);
});

it("Logged in, no existing cipher, a login field => We should NOT display menu (i.e. trainline)", () => {
const decisionArray: DecisionArray = {
Expand All @@ -382,9 +382,8 @@ describe("Autofill Service", () => {
hasMultipleScript: false,
field_visible: true,
field_viewable: false,
}
};

expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(false)

})
})
expect(evaluateDecisionArray(makeAction(decisionArray))).toBe(false);
});
});
Loading

0 comments on commit 896d576

Please sign in to comment.