feat: Send uploaded file size via querystring #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some `fetch` implementations like the one used in the Cozy Desktop client (i.e. using Chromium's network stack) don't allow setting the `Content-Length` header when sending stream bodies. With this limitation, the remote `cozy-stack` cannot run size checks until the whole file has been uploaded. If the file is large and too large for the available space or the file size limit, the uploading client can spend quite some time uploading it to end up receiving an error response. `cozy-stack` now allows passing the file size via the querystring parameter `Size` so those clients will get the benefits of early size checks.
doubleface
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
fetchimplementations like the one used in the Cozy Desktopclient (i.e. using Chromium's network stack) don't allow setting the
Content-Lengthheader when sending stream bodies.With this limitation, the remote
cozy-stackcannot run size checksuntil the whole file has been uploaded. If the file is large and too
large for the available space or the file size limit, the uploading
client can spend quite some time uploading it to end up receiving an
error response.
cozy-stacknow allows passing the file size via the querystringparameter
Sizeso those clients will get the benefits of early sizechecks.