feat: Acknowledge noSanitize in all file methods
#310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default document names are sanitized (i.e. trimmed) when making requests to the Cozy. However, some clients like Cozy Desktop require that the names they pass to `cozy-client-js` are passed on untouched to the Cozy (in case of Cozy Desktop, doing otherwise will lead to a de-synchronized state between the local and remote trees). We already have a `noSanitize` option that prevents the sanitation from happening but it's only available when creating files via the `create` method. We now add and use this option in all methods that would otherwise sanitize the document name by default.
LucsT
approved these changes
Feb 12, 2021
doubleface
approved these changes
Feb 12, 2021
|
We should have added at least one test in https://github.com/cozy/cozy-client-js/blob/master/test/unit/files.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default document names are sanitized (i.e. trimmed) when making
requests to the Cozy.
However, some clients like Cozy Desktop require that the names they
pass to
cozy-client-jsare passed on untouched to the Cozy (in caseof Cozy Desktop, doing otherwise will lead to a de-synchronized state
between the local and remote trees).
We already have a
noSanitizeoption that prevents the sanitationfrom happening but it's only available when creating files via the
createmethod.We now add and use this option in all methods that would otherwise
sanitize the document name by default.