Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cancel() method on intent service object #149

Merged
merged 3 commits into from
May 2, 2017

Conversation

gregorylegarec
Copy link
Contributor

No description provided.

@gregorylegarec gregorylegarec force-pushed the feat/intent-service-cancel branch 3 times, most recently from aa15cff to ac1b4a4 Compare May 2, 2017 00:29
@gregorylegarec gregorylegarec requested review from y-lohse and aenario May 2, 2017 00:29
}, /Intent service has already been terminated/)
})

it('should forbbid further calls to terminate()', async function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo here forbbid instead of forbid

Copy link
Contributor

@y-lohse y-lohse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gregorylegarec gregorylegarec force-pushed the feat/intent-service-cancel branch from 16d3730 to acdce72 Compare May 2, 2017 10:01
@gregorylegarec
Copy link
Contributor Author

Just cleaned my branch to remove my Merge commit.

@y-lohse y-lohse merged commit 3bcf704 into cozy:master May 2, 2017
@gregorylegarec gregorylegarec deleted the feat/intent-service-cancel branch May 30, 2017 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants