Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver's auction preprocessing total metric fix #3261

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

squadgazzz
Copy link
Contributor

The auction preprocessing job runs only once for each auction, which is achieved by using a mutex where other threads wait until the running job is completed. The total metric was placed incorrectly outside the lock, accumulating a lot of useless information where the preprocessing is already done, and other threads just read the value. This PR fixes it by only populating the metric when the async job is really executed.

@squadgazzz squadgazzz requested a review from a team as a code owner January 30, 2025 12:02
@squadgazzz squadgazzz changed the title Driver's auction preprocessing total metric fix Driver's auction preprocessing total metric fix Jan 30, 2025
@squadgazzz squadgazzz merged commit c060bb5 into main Jan 30, 2025
11 checks passed
@squadgazzz squadgazzz deleted the driver-auction-preprocessing-metric-fix branch January 30, 2025 16:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants