Fix a flaky e2e test #3183
Merged
Fix a flaky e2e test #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, could you run |
m-lord-renkse
approved these changes
Dec 30, 2024
Why didn't you like the one from the PR description? |
Oh my bad, the one from the description seems failing, but it is because the job was finished abruptly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
local_node_replace_ordere2e test. Currently, the whole protocol stack is getting started in the beginning. After creating a first order and before sending a replacement one, a new block is minted, which starts the auction preparation mechanism. Sometimes, the auction gets prepared before the replacement order is placed, making the test fail. This PR removes this redundant block mining request.A test run of the change: https://github.com/cowprotocol/services/actions/runs/12502462800?pr=3183 (failed due to the GH action execution timeout; all the tests passed).