-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRIVIAL] Fixed driver OpenAPI /reveal request definition #3164
Conversation
Reminder: Please consider backward compatibility when modifying the API specification.
Caused by: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in order to avoid renaming everything every time we add or remove a field we should consider renaming files, top level structs and API references to sth like [reveal_]request
and [reveal_]response
(same for /solve
and /settle
)
Co-authored-by: Martin Magnus <martin.beckmann@protonmail.com>
Co-authored-by: Martin Magnus <martin.beckmann@protonmail.com>
Renamed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests passing without adjustments in the code show that no breaking changes are introduced.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Co-authored-by: ilya <ilya@cow.fi>
Btw, I suppose, this is not a |
Description
OpenAPI driver
/reveal
request has 3 fields:solutionId
,submissionDeadlineLatestBlock
,auctionId
which is inconsistent with the source code, where/reveal
request has only 2 fields:solutionId
andauctionId
: source.Changes
/settle
and/reveal
endpoints have same API definition:Solution
, so I've created new API component:SolutionWithDeadline
and assigned it to/settle
endpoint. FromSolution
I've removedsubmissionDeadlineLatestBlock
field which now aligns with/reveal
endpoint source code.Renamed driver settle dto module
solution.rs
tosolution_with_deadline.rs
and name of the structSolution
toSolutionWithDeadline
.