Driver settle queue tests #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
287ccc1 to
5b27c13
Compare
a5ab68a to
7bcd92f
Compare
squadgazzz
commented
Nov 22, 2024
MartinquaXD
reviewed
Nov 28, 2024
There was a problem hiding this comment.
Using the ethrpc configurations seems weird to make this test work.
Did you consider using anvil's helper methods instead?
You could first disable auto mining and manually clear the mempool to make sure that transactions actually do not get mined so that the submission futures don't return.
de75f95 to
2efbcfe
Compare
MartinquaXD
approved these changes
Dec 18, 2024
sunce86
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
LG.
I think it's good to have these tests to make sure no regression bugs are introduced in the future.
However, since this is a bit risky change, I would prefer to have a live testing on staging:
- Enable only one solver - baseline
- Organize testing session (maybe backend team only) and spam staging with multiple orders.
# Conflicts: # crates/driver/src/domain/competition/mod.rs
# Conflicts: # crates/driver/src/domain/competition/mod.rs
# Conflicts: # crates/driver/src/tests/cases/buy_eth.rs # crates/driver/src/tests/cases/merge_settlements.rs # crates/driver/src/tests/cases/parallel_auctions.rs # crates/driver/src/tests/cases/settle.rs # crates/driver/src/tests/setup/mod.rs
# Conflicts: # crates/driver/src/domain/competition/mod.rs # crates/driver/src/infra/api/mod.rs # crates/driver/src/infra/api/routes/solve/mod.rs # crates/driver/src/infra/config/file/load.rs # crates/driver/src/infra/config/file/mod.rs # crates/driver/src/infra/solver/mod.rs
mstrug
approved these changes
Dec 21, 2024
# Conflicts: # crates/driver/src/infra/config/file/mod.rs
# Conflicts: # crates/driver/src/domain/competition/mod.rs # crates/driver/src/infra/api/error.rs # crates/driver/src/infra/observe/mod.rs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An attempt to properly test #3129. The idea is to send multiple
/settlerequests to the same driver to check that some will be discarded due to the settlement queue limit.Changes
anvilwith disabled auto-mining is used to accumulate/settlerequests in the queue.TooManyPendingSettlementsAPI error to properly identify the cause. I couldn't find a better way to ensure the logic is correct. Also, it might be helpful for all the parties to understand why a specific solution/settlement was discarded.default_settle_queue_sizeis reduced to2, since 1 ongoing settlement(dequeued) + 2 more in the queue make it3pending in total, which is high enough IMO.Settlestruct, which stores the/settleendpoint response data in order to fix a compilation issue. More details: Driver settle queue tests #3133 (comment)How to test
This is the test.