Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EASY] Add instrumentation to update_events() #3126

Merged
merged 2 commits into from
Nov 20, 2024
Merged

[EASY] Add instrumentation to update_events() #3126

merged 2 commits into from
Nov 20, 2024

Conversation

m-lord-renkse
Copy link
Contributor

Description

It is very hard to debug via logs any issue related with the indexer. Added an instrumentation to differentiate the origin (contract) of the indexer.

@m-lord-renkse m-lord-renkse changed the title Add instrumentation to update_events() [TRIVIAL] Add instrumentation to update_events() Nov 14, 2024
@m-lord-renkse m-lord-renkse changed the title [TRIVIAL] Add instrumentation to update_events() [EASY] Add instrumentation to update_events() Nov 14, 2024
@m-lord-renkse m-lord-renkse marked this pull request as ready for review November 14, 2024 08:47
@m-lord-renkse m-lord-renkse requested a review from a team as a code owner November 14, 2024 08:47
mstrug
mstrug approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@mstrug mstrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@m-lord-renkse
Copy link
Contributor Author

Tested, this is what the log looks like:

2024-11-14T09:26:20.674Z DEBUG address{address=[0x9008d19f58aabd9ed0d60971565aa8510560ab41]}: shared::event_handling: blocks to update into last_handled_blocks: ...

@m-lord-renkse m-lord-renkse merged commit be06e4f into main Nov 20, 2024
11 checks passed
@m-lord-renkse m-lord-renkse deleted the add-instrumentation-to-update-events branch November 20, 2024 09:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fleupold fleupold fleupold approved these changes

@mstrug mstrug mstrug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-lord-renkse @fleupold @mstrug