Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsynchronised run loop #3050

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Remove unsynchronised run loop #3050

merged 5 commits into from
Oct 11, 2024

Conversation

m-lord-renkse
Copy link
Contributor

Description

Since now all the e2e tests are working in sync-to-blockchain mode (see #3040) , we can remove the unsynchronized mode.

Changes

  • Remove unsynchronized mode

How to test

  1. Regression tests

@m-lord-renkse m-lord-renkse marked this pull request as ready for review October 10, 2024 14:47
@m-lord-renkse m-lord-renkse requested a review from a team as a code owner October 10, 2024 14:47
MartinquaXD
MartinquaXD reviewed Oct 10, 2024
View reviewed changes
crates/autopilot/src/maintenance.rs Outdated Show resolved Hide resolved
crates/autopilot/src/shadow.rs Show resolved Hide resolved
sunce86
sunce86 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@sunce86 sunce86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

squadgazzz
squadgazzz approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@squadgazzz squadgazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

MartinquaXD
MartinquaXD approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the background task --auction-update-interval is now also no longer in use. Other than that the PR looks good.
Approved assuming that will also get removed before merging.

@m-lord-renkse m-lord-renkse enabled auto-merge (squash) October 11, 2024 07:29
@m-lord-renkse m-lord-renkse merged commit 74eed7b into main Oct 11, 2024
11 checks passed
@m-lord-renkse m-lord-renkse deleted the remove-run-loop-mode branch October 11, 2024 07:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinquaXD MartinquaXD MartinquaXD approved these changes

@sunce86 sunce86 sunce86 approved these changes

@squadgazzz squadgazzz squadgazzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m-lord-renkse @MartinquaXD @sunce86 @squadgazzz