CoW AMM: Implement archive node URL as an option to build CoW AMM Web3 #3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c94923a to
f65d3c8
Compare
squadgazzz
reviewed
Oct 9, 2024
crates/autopilot/src/run.rs
Outdated
Comment on lines
376
to
378
| let cow_amm_web3 = args.archive_node_url.as_ref().map_or(web3.clone(), |url| { | ||
| boundary::web3_client(url, &args.shared.ethrpc) | ||
| }); |
There was a problem hiding this comment.
General question: will cow amm support work properly without an archive node being provided?
There was a problem hiding this comment.
Yeah, I've worked on that for a while but it turned out a bit ugly so I didn't open a PR for that yet. Should resurrect the work soon. 🤞
MartinquaXD
approved these changes
Oct 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CoW AMM currently relies on archive nodes. Add the possibility to build
web3for CoW AMM from an archive node URL.Changes
web3for CoW AMM from the given URLHow to test