Move settlement updater #3018
Merged
Move settlement updater #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-lord-renkse
approved these changes
Sep 27, 2024
MartinquaXD
reviewed
Sep 27, 2024
There was a problem hiding this comment.
nit: The "to be renamed component" is the only one that creates settlement::Settlement instances (the infra is the only one consuming it). That means settlement::Settlement::new() can now be made private. That way we ensure that we don't have other components create these types by accident.
MartinquaXD
approved these changes
Sep 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OnSettlementEventUpdaterwas previously refactored and ended up being dependent ondomainandinfraobjects only.That means it is ready to be moved to a proper place inside
domain.Changes
How to test
Existing e2e tests.