Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only new format of solve response #3001

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

sunce86
Copy link
Contributor

@sunce86 sunce86 commented Sep 17, 2024

Description

A follow up for #2984 where we added a new format of /solve response, after which there were two ways to submit /solve response.

This PR deprecates the old way and uses only the new format and adjusts the autopilot domain code to use it (which is needed so we can finally merge #2730

Will not merge it until all solvers switch to new format.

@sunce86 sunce86 self-assigned this Sep 17, 2024
@sunce86 sunce86 requested a review from a team as a code owner September 17, 2024 13:32
Copy link
Contributor

@m-lord-renkse m-lord-renkse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MartinquaXD
Copy link
Contributor

Will not merge it until all solvers switch to new format.

So this will sit here unmerged for a while. Could you please mark this as blocked and a draft until then?

@sunce86
Copy link
Contributor Author

sunce86 commented Sep 18, 2024

Will not merge it until all solvers switch to new format.

So this will sit here unmerged for a while. Could you please mark this as blocked and a draft until then?

Will be merged on Monday, since I announced to solvers that it will be live on weekly release of 1st of October (and no objections were raised). Until Monday approvals will land hopefully.

@sunce86 sunce86 merged commit f469961 into main Sep 24, 2024
11 checks passed
@sunce86 sunce86 deleted the force-traded-order-new-format branch September 24, 2024 14:24
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants