Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRIVIAL] Drop redundant maintenance metric #2985

Merged
merged 2 commits into from
Sep 13, 2024
Merged

[TRIVIAL] Drop redundant maintenance metric #2985

merged 2 commits into from
Sep 13, 2024

Conversation

squadgazzz
Copy link
Contributor

The dropped metric actually duplicates the service maintenance time metric:

services/crates/autopilot/src/run_loop.rs

Lines 773 to 776 in e841020

/// Tracks the time spent running maintenance. This mostly consists of
/// indexing new events.
#[metric(buckets(0.01, 0.05, 0.1, 0.2, 0.5, 1, 1.5, 2, 2.5, 5))]
service_maintenance_time: prometheus::Histogram,

@squadgazzz squadgazzz requested a review from a team as a code owner September 13, 2024 07:33
@squadgazzz squadgazzz merged commit 92b60c8 into main Sep 13, 2024
11 checks passed
@squadgazzz squadgazzz deleted the drop-redundant-maintenance-metric branch September 13, 2024 10:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinquaXD MartinquaXD MartinquaXD approved these changes

@sunce86 sunce86 sunce86 approved these changes

@m-lord-renkse m-lord-renkse m-lord-renkse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@squadgazzz @MartinquaXD @sunce86 @m-lord-renkse