fix(limit-orders): update price and amounts when tokens changed #5356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
68afe72 to
9e32a8d
Compare
9e32a8d to
241d119
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes https://www.notion.so/cownation/Price-is-wrong-when-change-a-token-using-token-selector-1858da5f04ca802c99e1caa36375b7d5
This problem more likely comes from #4668 fix. At least I can reproduce it on prod now.
In useUpdateActiveRate() we have a logic which depends on
isRateFromUrlflag.Mainly, it serves for keeping amounts static after coming from another trade widget.
But we should not prevent amounts and price update when we change tokens.
So, we reset
isRateFromUrlflag when at least one of the tokens is changed.To Test