Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(legacy-core): forgify transfer authenticator proxy contract ownership script #102

Closed
Tracked by #76
mfw78 opened this issue Jun 3, 2024 · 1 comment · Fixed by #158
Closed
Tracked by #76

chore(legacy-core): forgify transfer authenticator proxy contract ownership script #102

mfw78 opened this issue Jun 3, 2024 · 1 comment · Fixed by #158
Assignees
@fedgiac
Labels
E:5.2 Contracts migrations See https://github.com/cowprotocol/pm/issues/32 for details

Comments

@mfw78
Copy link
Contributor

mfw78 commented Jun 3, 2024

No description provided.

@mfw78 mfw78 mentioned this issue Jun 3, 2024
Open
22 tasks
@mfw78 mfw78 changed the title chore(legacy-core): forgify transfer authenticator proxy contract ownership script (federico) chore(legacy-core): forgify transfer authenticator proxy contract ownership script Jun 3, 2024
@mfw78 mfw78 added the E:5.2 Contracts migrations See https://github.com/cowprotocol/pm/issues/32 for details label Jun 3, 2024
@mfw78 mfw78 transferred this issue from cowprotocol/pm Jun 3, 2024
@fedgiac
Copy link
Contributor

fedgiac commented Jun 3, 2024

Requires #99.

@fedgiac fedgiac mentioned this issue Jun 6, 2024
Merged
fedgiac added a commit that referenced this issue Jun 7, 2024
@fedgiac
chore: rewrite transferOwnership script to use Foundry (#158)
76e2363 
## Description

The transferOwnership script has been ported to Foundry, with feature
parity, including tests.

There was the need for a few workarounds in the tests, mostly because
`prank` and `broadcast` aren't compatible with each other and because
our proxy is based on Solidity 0.7 and its code isn't directly available
in this repo.

## Test Plan

New tests.
I also deployed a new set of contracts on Sepolia and used the script to
change the owner and manager. You can see the two resulting transactions
for the
[manager](https://sepolia.etherscan.io/tx/0xe4d4499c66f696c671374ffc3f7255dc05fc09b9643af85e4c0e4243919f044a#eventlog)
and the
[owner](https://sepolia.etherscan.io/tx/0x42a592e04a3a76463b51bff67f38a7195875400e41b7b59737ac8dd41dcb45a7#eventlog).

## Related Issues

Closes #102
Closes #103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedgiac fedgiac

Labels
E:5.2 Contracts migrations See https://github.com/cowprotocol/pm/issues/32 for details
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: rewrite transferOwnership script to use Foundry cowprotocol/contracts
2 participants
@mfw78 @fedgiac