Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6 breakdown pt3 - add order_book module #12

Merged
merged 26 commits into from
Sep 10, 2024
Merged

#6 breakdown pt3 - add order_book module #12

merged 26 commits into from
Sep 10, 2024

Conversation

yvesfracari
Copy link
Collaborator

@yvesfracari yvesfracari commented Aug 15, 2024 •
edited
Loading

original PR: #6

  • Added OrderBook API implementation
  • Created order posting end-to-end example (you can try if you want to test the changes)
  • Implemented order quoting and creation functionality
  • Added support for order signing and domain handling
  • Integrated python-dotenv for environment variable management
  • Updated Chain enum with correct Sepolia explorer URL
  • Added tests for OrderBook API methods

@yvesfracari yvesfracari changed the title #6 breakdown pt4 - add order_book module #6 breakdown pt3 - add order_book module Aug 15, 2024
@yvesfracari yvesfracari marked this pull request as ready for review August 16, 2024 13:02
@yvesfracari yvesfracari requested a review from mfw78 as a code owner August 16, 2024 13:02
@yvesfracari yvesfracari requested review from ribeirojose and mendesfabio and removed request for mfw78 August 20, 2024 13:25
Base automatically changed from cow-3-contracts to main September 6, 2024 15:20
@ribeirojose
Copy link
Collaborator

@gabrielfior added the e2e test to get a quote, send an unrealistic order and also cancel it. I also took the liberty used VCR because running the test live will result in intermittent failures given sometimes there's no liquidity for solvers to solve this, especially in Sepolia. Anyone can rerun the test using pytest --record-mode=rewrite

yvesfracari
yvesfracari commented Sep 10, 2024
View reviewed changes
.env.example Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
cow_py/common/api/api_base.py Outdated Show resolved Hide resolved
@ribeirojose ribeirojose merged commit 20bdb73 into main Sep 10, 2024
3 checks passed
@ribeirojose ribeirojose deleted the cow-4-order-book branch September 10, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ribeirojose ribeirojose ribeirojose approved these changes

@gabrielfior gabrielfior gabrielfior approved these changes

@mendesfabio mendesfabio Awaiting requested review from mendesfabio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yvesfracari @ribeirojose @gabrielfior